[Webkit-unassigned] [Bug 57250] check-webkit-style confused by two ChangeLog entries in a row from same user

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57250





--- Comment #13 from David Levin <levin at chromium.org>  2011-03-29 09:12:47 PST ---
(In reply to comment #11)
> (From update of attachment 87281 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87281&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py:89
> > +                          '2011-01-01  Patrick Gansterer  <paroga at paroga.com (:paroga) (c)>\n'
> > +                          '\n        Example bug'
> > +                          '\n        http://trac.webkit.org/changeset/12345\n')
> 
> The other lines have the \n only at the end

Fixed.

> 
> > Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py:111
> > +        self.assert_no_error([],
> > +                             '2011-01-01  Patrick Gansterer  <paroga at paroga.com (:paroga) (c)>\n'
> > +                             '\n'
> > +                             '        Example bug\n'
> > +                             '        http://bugs.webkit.org/show_bug.cgi?id=12345\n')
> 
> Thx, maybe we can add and "invalid" entry with emty range too.

I don't understand because I think the lines which start with
  self.assert_error(2, range(2, 5), 'changelog/bugnumber'
already do this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.