[Webkit-unassigned] [Bug 23124] RTL: Directionality always reset on hard line break

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23124





--- Comment #26 from Levi Weintraub <leviw at chromium.org>  2011-03-29 08:48:47 PST ---
(From update of attachment 87328)
View in context: https://bugs.webkit.org/attachment.cgi?id=87328&action=review

Thanks for the review. I'll correct your points :)

>> Source/WebCore/platform/text/BidiContext.cpp:82
>> +    Vector<BidiContext*> contexts;
> 
> Either this should have inline capacity of 64 (to avoid ever mallocing) or you shoudl do this in two passes.  One which makes a clone of the list w/o unicodeEmbeddings, and a second walk which fixes the levels.
> 
> I think I'm slightly more in favor of doing two passes.  But it's really up to you.  A linked list walk is also expensive, but probably less expensive than a malloc.  Although we can avoid the malloc with the inline capcity.  so again, up to you.

I'd love to do a 2-pass solution, but I don't believe we can do this properly, since each context derives its level from those below it, and we need a parallel data structure to walk from hte bottom to the top.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.