[Webkit-unassigned] [Bug 56384] XML viewer is not shown when frame has non-null opener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56384


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87337|review?                     |review-
               Flag|                            |




--- Comment #18 from Pavel Feldman <pfeldman at chromium.org>  2011-03-29 08:32:04 PST ---
(From update of attachment 87337)
View in context: https://bugs.webkit.org/attachment.cgi?id=87337&action=review

> Source/WebCore/xml/XMLViewer.xsl:268
> +                var domSubTreeModifiedListener;

This variable can be declared in the onWebKitXMLViewerLoad.

> Source/WebCore/xml/XMLViewer.xsl:274
> +                        if (!domSubTreeModifiedListener) {

Can the opposite happen?

> Source/WebCore/xml/XMLViewer.xsl:282
> +                    if (!window.onWebKitXMLViewerSourceXMLLoaded)

I don't follow the code. Can you explain what is happening in this load handler?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.