[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54623





--- Comment #8 from Eric Seidel <eric at webkit.org>  2011-03-29 06:36:23 PST ---
(From update of attachment 87158)
View in context: https://bugs.webkit.org/attachment.cgi?id=87158&action=review

I think the approach seems fine (assuming its mirrors what we do when scrollbars are on the right).  But the code needs further cleanup to abstract these functions nicely.

> Source/WebCore/rendering/RenderBlock.cpp:1751
> +    if (style()->isHorizontalWritingMode() && !style()->isLeftToRightDirection())

This should be a style()->showScrollbarOnLeft() check.

> Source/WebCore/rendering/RenderBox.cpp:479
> +IntRect RenderBox::contentBoxRect() const {

style.  { on next line.

> Source/WebCore/rendering/RenderBox.cpp:481
> +    if (!style()->isLeftToRightDirection())

Same here.  We may decide this is not related to writign direction at a later time.  Whether we show a scrollbar on the left or right shoudl be an independent function check.

> Source/WebCore/rendering/RenderBox.cpp:1130
> +            clipX += layer()->verticalScrollbarWidth(relevancy);
>          clipWidth -= layer()->verticalScrollbarWidth(relevancy);

Seems we should cache this value instead of asking it twice...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.