[Webkit-unassigned] [Bug 55883] [Gtk] Consistent crash from Google/ARIA combobox click

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 06:23:40 PDT 2011


--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2011-03-29 06:23:40 PST ---
(In reply to comment #3)
> [...]
> Perhaps a way to get this fixed would be to try to avoid calling to 
> firstChild() in accessibilityPlatformIncludesObject() as a rule of thumb, or 
> just removing completely this code:
>    [...]
>    // We expect the parent of a table cell to be a table.
>    AccessibilityObject* child = firstChild();
>    if (child && child->roleValue() == CellRole)
>        return IgnoreObject;
>    [...]
> ... and then trying to get some equivalent code for that in case we think it's 
> really needed after all (which is something I currently have doubts about, 
> since just removing that fixed the bug and doesn't get any unit/layout test 
> failing).

I've just done some investigation and found out that these lines of code were introduced along with SVN revision 55623 (http://trac.webkit.org/changeset/55623), where a new layout test was also added: http://trac.webkit.org/changeset/55623

I've executed that test after completely removing those lines and still succeeds, as well as the rest of the non-skipped a11y tests, hence I think perhaps that code is no longer needed so it could be safely removed.

Expect a patch in a while, then...

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list