[Webkit-unassigned] [Bug 56918] [Qt] Teach build-jsc how to build JavaScriptCore on Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56918


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87130|review?                     |review+
               Flag|                            |




--- Comment #4 from Csaba Osztrogonac <ossy at webkit.org>  2011-03-29 03:17:47 PST ---
(From update of attachment 87130)
View in context: https://bugs.webkit.org/attachment.cgi?id=87130&action=review

I'm sure if it works with a little fix I suggested, but it is a little 
nasty hack, because the original code was hacked in itself.

r=me to go ahead, but we really need a serious refactor for buildQMakeProject() in the near future.

> Tools/Scripts/webkitdirs.pm:1637
>      if (grep { $_ eq "CONFIG+=webkit2"} @buildArgs) {
>          push @subdirs, "WebKit2";
>          if ( -e sourceDir() ."/Tools/DerivedSources.pro" ) {

We need one more if (!$project) guard to avoid building WebKit2, MiniBrowser and WTR.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.