[Webkit-unassigned] [Bug 57250] check-webkit-style confused by two ChangeLog entries in a row from same user

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57250





--- Comment #10 from David Levin <levin at chromium.org>  2011-03-29 01:31:37 PST ---
(In reply to comment #8)
> (From update of attachment 87279 [details])
> We ahve code for fixing up ChagneLog diffs somewehre.  Seems check-webkit-style would only want to scan the current ChangeLog and ignore the rest of hte diff.  (I haven't really looked at your patch, mabye that's what it does)

Yes basically it does only look at the current ChangeLog.

(In reply to comment #7)
> (From update of attachment 87279 [details])
> > Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py:-43
> > -
> 
> Hmmm, my style checker wanted this empty line before def.

It still does. It doesn't complain about my patch because the error gets filtered out (due to it being a deleted line) -- tricky case.

Thanks for noticing.

Addressed the other two comments also.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.