[Webkit-unassigned] [Bug 57250] check-webkit-style confused by two ChangeLog entries in a row from same user

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 01:20:42 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57250





--- Comment #7 from Patrick R. Gansterer <paroga at paroga.com>  2011-03-29 01:20:42 PST ---
(From update of attachment 87279)
View in context: https://bugs.webkit.org/attachment.cgi?id=87279&action=review

LGTM

> Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py:-43
> -

Hmmm, my style checker wanted this empty line before def.

> Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py:79
> +                          '        Example bug'
> +                          '\n'

\n into the same line

> Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py:106
>      def test_no_error(self):

Maybe you can add an empty one too

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list