[Webkit-unassigned] [Bug 56912] Web Inspector: move node searching and node highlight related methods from InspectorAgent to DOMAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56912





--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2011-03-28 23:23:07 PST ---
(In reply to comment #9)
> (From update of attachment 86597 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86597&action=review
> 
> > Source/WebCore/inspector/InspectorDOMAgent.cpp:65
> > +#include "InspectorAgent.h"
> 
> 1) I think it is very wrong to add a dependency from InspectorDOMAgent to InspectorResourceAgent.

read as of InspectorDOMAgent from InspectorResourceAgent

> 2) I also think it is very wrong to put dependency from any agent to InspectorAgent
> 

read as of any agent from InspectorAgent

> I think reasons above are sufficient to roll this change out.

Morning brains confused, blood boils :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.