[Webkit-unassigned] [Bug 56912] Web Inspector: move node searching and node highlight related methods from InspectorAgent to DOMAgent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56912


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86597|review+                     |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2011-03-28 23:04:31 PST ---
(From update of attachment 86597)
View in context: https://bugs.webkit.org/attachment.cgi?id=86597&action=review

This is r- for several reasons, I wonder how it ended up with r+.

> Source/WebCore/inspector/DOMNodeHighlighter.h:37
> +namespace DOMNodeHighlighter {

Why custom namespace? What is wrong with using WebCore? This is not standard approach afaik.

> Source/WebCore/inspector/DOMNodeHighlighter.h:39
> +void DrawNodeHighlight(GraphicsContext&, Node*);

Methods in WebCore start with lower case.

> Source/WebCore/inspector/Inspector.json:676
> +                "name": "setSearchingForNode",

DOM domain is documented, you should not introduce commands that are not documented into it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.