[Webkit-unassigned] [Bug 56434] REGRESSION (r64712): Safari removes the first blank line in a textarea

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56434





--- Comment #18 from Kent Tamura <tkent at chromium.org>  2011-03-28 21:19:31 PST ---
(From update of attachment 87255)
View in context: https://bugs.webkit.org/attachment.cgi?id=87255&action=review

> LayoutTests/fast/forms/textarea-newline-expected.txt:10
> +No line feed. 
> + 
> +One line feed after textarea tag is ignored. 
> + 
> +Two line feeds after textarea tag and the first one is ignored. 
> + 
> +One line feed escaped character after textarea tag and line feed and both are not ignored. 
> + 
> +Two line feed escaped characters after textarea tag and both are not ignored. 

The readability of the test result is not good.  These five sentences are confusing.
I recommend:
 - Remove them, and
 - Print them by debug() function, or change ID names.

e.g.
debug('No line feed.');
var textarea = document.getElementById('Madoka');
shouldBe('textarea.value', '"Madoka"');

or

Replacing id="Madoka" with id="no-line-feed", and
shouldBe('document.getElementById("no-line-feed").value', '"Madoka"');

> LayoutTests/fast/forms/textarea-newline.html:46
> +var textarea = document.getElementById('Madoka');
> +shouldBe('textarea.value', '"Madoka"');
> +
> +var textarea = document.getElementById('Sayaka');

Declaring "var textarea" multiple times is not good.

> Source/WebCore/ChangeLog:12
> +        A linefeed removal after a textarea tag is originally processed in WebCore::HTMLTextAreaElement::defaultValue().
> +        But HTML5 tree builder now removes the linefeed. It means linefeed removal happens twice.
> +        And devalutValue() removal is not needed anymore.

Great.  Thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.