[Webkit-unassigned] [Bug 57250] check-webkit-style confused by two ChangeLog entries in a row from same user

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57250





--- Comment #4 from David Levin <levin at chromium.org>  2011-03-28 17:35:32 PST ---

I know what is going wrong with one of them:
1. The diff came out "funny" due to the entries in succession. When the checker logs the error for line 15 (for the following entry which has no bug number). the error filter allows the error to go through because this line is in the diff.

2. For bug 57262, the checker was correct that the ChangeLog entry starting at line 13 had no bug number but line 13 was not part of the patch for the error filter should have removed this.

We can fix these by limiting the lines given to the main check function to be just the added lines. (Of course, we'll have to adjust the lines where the errors are reported if this approach is taken.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.