[Webkit-unassigned] [Bug 57138] WebSocket urls should always be encoded as UTF-8

Mon Mar 28 12:35:56 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=57138

Joe Mason <jmason at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87005|0                           |1
        is obsolete|                            |
  Attachment #87180|                            |review?, commit-queue?
               Flag|                            |

--- Comment #4 from Joe Mason <jmason at rim.com>  2011-03-28 12:35:55 PST ---
Created an attachment (id=87180)
 --> (https://bugs.webkit.org/attachment.cgi?id=87180&action=review)
updated patch

How's this?

Quite a few ways to implement Document::completeURLWithUTF8 - since from the comments completeURL seems to be performance critical, I chose to make both completeURL and completeURLWithUTF8 into inlines wrapper to a new func which takes a bool param to force UTF-8 or not.  The alternative is to not touch completeURL, and copy the code to a new function which differs only in how it uses m_decoder.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.