[Webkit-unassigned] [Bug 57257] New: Use willCacheResponse on Windows instead of shouldCacheResponse

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57257

           Summary: Use willCacheResponse on Windows instead of
                    shouldCacheResponse
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: psolanki at apple.com
                CC: darin at apple.com, ap at webkit.org, mitz at webkit.org,
                    jberlin at webkit.org


ResourceLoader.h has two different callback methods.

On Mac - virtual NSCachedURLResponse* willCacheResponse(ResourceHandle*, NSCachedURLResponse*);
On Windows - virtual bool shouldCacheResponse(ResourceHandle*, CFCachedURLResponseRef);

The method on Windows should match the one on Mac. It should be

virtual CFCachedURLResponseRef willCacheResponse(ResourceHandle*, CFCachedURLResponseRef);

I am adding the above method for Mac when using CFNetwork (see bug 51836). Windows code should use that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.