[Webkit-unassigned] [Bug 9272] Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9272





--- Comment #14 from Eric Seidel <eric at webkit.org>  2011-03-28 09:28:54 PST ---
(From update of attachment 87150)
View in context: https://bugs.webkit.org/attachment.cgi?id=87150&action=review

> Source/WebCore/rendering/InlineFlowBox.cpp:245
> +            RenderObject* current = logicallyLastRunRenderer->parent();
> +            while (current && !current->isRenderBlock()) {
> +                if (current == renderer())
> +                    break;
> +                current = current->parent();
> +            }

isn't this jsut containingBlock()? If so, it seems "current" is th wrong name.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:580
> +    if (BidiRun* run = resolver.logicallyLastRun()) {

I would have early returned instead of makign a block

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.