[Webkit-unassigned] [Bug 57233] move directionOfEnclosingBlock() to be global so that it could be reused

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 08:27:25 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57233


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87147|review?                     |review-
               Flag|                            |




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-28 08:27:25 PST ---
(From update of attachment 87147)
View in context: https://bugs.webkit.org/attachment.cgi?id=87147&action=review

> Source/WebCore/editing/SelectionController.cpp:339
> +    return WebCore::directionOfEnclosingBlock(m_selection.extent().anchorNode()); 

This isn't right.  You're calling anchorNode() here even though the original code called containerNode().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list