[Webkit-unassigned] [Bug 25298] Ctrl + Right/Left arrow move forward/backward through document instead of right/left in RTL text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25298





--- Comment #42 from Xiaomei Ji <xji at chromium.org>  2011-03-28 04:28:57 PST ---
(In reply to comment #39)
> I think we should consider landing the test cases first w/o any of the code changes to document our current (broken) behavior.


The problem is currently, the behavior is ctrl-arrow moves caret by word in logical order.
So, if we land the test case first, only the pure English in LTR block will behaves as expected (in which case, the visual order is the same as logical order). All other cases (RTL text in LTR block, LTR or RTL tet in RTL block, bidi text in either LTR block or RTL block) will be wrong. And we will need to replace all those results when landing the correct behavior.

> 
> I also worry that we may be trying to fix too much in one go.  Some users commented above that there may be simpler solutions which would be "good enough" for a first pass, and we could continue to iterate from there.

Well, I am not quite sure how to split the current patch in to different small ones.
One tweak I can do is that: for the pure RTL text in LTR block or pure LTR text in RTL block, since the logical order is exactly the opposite of visual order, having a short cut to get the visual order by getting reverse order of logical orders. 
I need to check whether that taking care of the spaces correctly (as to where should stop -- right of space or left of space when space is used as word breaker).

And, this approach wont work for bidi text at all, and it is totally different approach from current patch.


> 
> End result: I think we should do everything possible to make this change in several smaller pieces.  Landing the layout tests w/o any code changes is one easy piece to break off.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.