[Webkit-unassigned] [Bug 53747] Add some dynamic annotations to JavaScriptCore/wtf

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53747





--- Comment #49 from Timur Iskhodzhanov <timurrrr at google.com>  2011-03-28 04:00:44 PST ---
(In reply to comment #47)
> > Do you think it's worth changing to C++? 
> 
> Yes. Keeping it as C would be an exception, and let's not make an exception if that's not required.
Done

> > Mark pointed out that the annotations may be unreadable for non-experts.
> > This is one of the reasons to keep at least *some* comments.
> If one sees a mysterious WTF_ANNOTATE_HAPPENS_BEFORE macro, they should jump to definition and read a comment there. A comment at call site can explain why we need it here in particular, not what it is.
> I don't think that an external link is a particularly good thing to have in WebKit sources, but it's OK.
Done - removed the comment from ThreadSafeRefcounted.h, added more comments to DynamicAnnotations.h

> > > I suspect that you need to add forwarding headers in WebKit, WebKit2 and other projects
> > > which probably include ThreadSafeShared indirectly. I wish EWS could tell us.
How can I do that?
> > How can I do that?
> > Is there an automated tool to do that?
> There is no automated tool to add forwarding headers. You just need to build on Mac, and add necessary headers in each project complaining that it can't find them.

$ ./Tools/Scripts/build-webkit
...
** BUILD SUCCEEDED **
===========================================================
 WebKit is now built (1h:10m:36s). 
 To run Safari with this newly-built code, use the
 "Tools/Scripts/run-safari" script.
===========================================================

How can I test "WebKit2 and other projects" locally?
Should I?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.