[Webkit-unassigned] [Bug 48512] [GTK] Implement sample browser app for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48512





--- Comment #22 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-03-28 03:54:07 PST ---
(From update of attachment 86961)
View in context: https://bugs.webkit.org/attachment.cgi?id=86961&action=review

> Tools/MiniBrowser/gtk/main.c:66
> +    g_signal_connect(G_OBJECT(item), "clicked", G_CALLBACK(goBackCallback), webView);

g_signal_connect macros receive a gpointer, so you can avoid casts and simply use g_signal_connect(item, ...);

> Tools/MiniBrowser/gtk/main.c:138
> +    gchar *fileURL = filenameToURL(uri);

I think we could/should use g_file_new_for_commandline_arg() when argc > 1 and then simply g_file_get_uri() instead of filenameToURL. Do we really need to check whether the file exists when it's a local path?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.