[Webkit-unassigned] [Bug 57186] Web Inspector: refactor ResourceTreeModel to remove poor dependencies.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 03:24:23 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57186


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87081|review?                     |review+
               Flag|                            |




--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2011-03-28 03:24:22 PST ---
(From update of attachment 87081)
View in context: https://bugs.webkit.org/attachment.cgi?id=87081&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:62
> +        WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResourceFinished, this._onResourceUpdated, this);

Please call this before getCachedResources.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:80
> +    frames: function(parentFrameId)

nuke it

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:191
> +        this._resourcesByURL[resource.url] = resource;

_resourcesByURL -> _resourceByURL

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list