[Webkit-unassigned] [Bug 57182] implement onerror events for <link rel=prefetch>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57182





--- Comment #2 from Adam Barth <abarth at webkit.org>  2011-03-27 13:15:12 PST ---
(From update of attachment 87068)
View in context: https://bugs.webkit.org/attachment.cgi?id=87068&action=review

> Source/WebCore/ChangeLog:22
> +        * html/HTMLLinkElement.cpp:
> +        (WebCore::HTMLLinkElement::parseMappedAttribute):
> +        (WebCore::HTMLLinkElement::onloadTimerFired):
> +        (WebCore::HTMLLinkElement::notifyFinished):
> +        * loader/cache/CachedImage.cpp:
> +        * loader/cache/CachedImage.h:
> +        * loader/cache/CachedResource.cpp:
> +        (WebCore::CachedResource::checkNotify):
> +        (WebCore::CachedResource::data):
> +        (WebCore::CachedResource::error):
> +        * loader/cache/CachedResource.h:
> +        * loader/cache/CachedScript.cpp:
> +        * loader/cache/CachedScript.h:

You should explain why you're making changes to all these different files.  This ChangeLog is calling out for information.  Also, I feel like this patch is the result of a long discussion.  It might be helpful to include some of the reasons why we're making this change in the ChangeLog.  You don't need to write a whole book, but something more than just empty boilerplate is probably a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.