[Webkit-unassigned] [Bug 12499] External <use> xlink:href references do not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=12499





--- Comment #55 from Rob Buis <rwlbuis at gmail.com>  2011-03-27 12:30:07 PST ---
(From update of attachment 86746)
View in context: https://bugs.webkit.org/attachment.cgi?id=86746&action=review

Overall the code looks good. Some of the asserts and returns on document testing may need good studying, but I think it is done correct. Apart from the minor gripes above I think a few more tests are needed.

> Source/WebCore/ChangeLog:9
> +        (Currently it only needs to handle SVG documents.)

Don't forget the overall goal. I'd personally say "Support external references on <use> by introducing CachedDocument, which handles document subresources."

> Source/WebCore/ChangeLog:10
> +        An instance of this class is a member in SVGUseElement.

This line is not very helpful and can be discarded. Better may be to add such info here:
* svg/SVGUseElement.h: store CachedDocument

> Source/WebCore/loader/cache/CachedDocument.cpp:73
> +    // FIXME: this should not be SVG-specific. Try Document::create.

Is the FIXME still valid?

> Source/WebCore/svg/SVGUseElement.cpp:130
> +                KURL kurl(document()->baseURI(), href());

Better just use url instead of kurl.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.