[Webkit-unassigned] [Bug 52614] [Qt] Fix LoadHTMLStringItem::invoke() after r75966

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52614





--- Comment #4 from Jessie Berlin <jberlin at webkit.org>  2011-03-27 08:12:06 PST ---
(From update of attachment 79783)
View in context: https://bugs.webkit.org/attachment.cgi?id=79783&action=review

I am not a reviewer, and you should probably get somebody a little more familiar with the Qt platform to review it, but this overall looks good to me!

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:889
> +// API Candidate?

What does this comment mean? API in what sense? (Is there a separate API for DRT?)

> Tools/DumpRenderTree/qt/WorkQueueItemQt.cpp:31
> +#include "../../../Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h"

I am not familiar with the Qt port style, but what happens if this file gets moved into some sub-directory, etc? Do all such paths have to be updated? Is there no way to set it up so that you can just include "DumpRenderTreeSupportQt.h" and add this path to the include paths?

> Tools/DumpRenderTree/qt/WorkQueueItemQt.h:85
> +    LoadAlternateHTMLStringItem(const QString& content, const QString &baseURL,  const QString &failingURL, QWebPage *page)

Extra space here between "&baseURL," and "const QString"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.