[Webkit-unassigned] [Bug 57178] New: InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57178

           Summary: InlineBox::prevOnline and
                    InlineBox::prevOnlineExists() are confusing and should
                    be renamed
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: hyatt at apple.com, mitz at webkit.org,
                    yael.aharon at nokia.com, xji at chromium.org,
                    rniwa at webkit.org


InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed

prevOnline() just returns m_prev and is probably named with "onLine" to indicate that it's on the same line (and not a prev/next in the sense of a RenderLineBoxList).

prevOnlineExists() answers the question of if there is a previous line box on the same line, not necessarily within the current InlineFlowBox container.

For example, the following code is wrong:

prevOnlineExists() && prevOnline()->foo()

One of these should be renamed to prevent confusion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.