[Webkit-unassigned] [Bug 57170] Remove comma at end of enum. Solaris 10/Sun Studio 12 CC don't like trailing comma's on enums

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57170





--- Comment #3 from Ben Taylor <bentaylor.solx86 at gmail.com>  2011-03-27 03:20:56 PST ---
(In reply to comment #2)
> Attachment 87052 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> 
> Source/JavaScriptCore/wtf/MessageQueue.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/image-decoders/ImageDecoder.h:65:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/network/ResourceRequestBase.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/graphics/BitmapImage.h:164:  One space before end of line comments  [whitespace/comments] [5]
> Total errors found: 4 in 14 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

(In reply to comment #2)
> Attachment 87052 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> 
> Source/JavaScriptCore/wtf/MessageQueue.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/image-decoders/ImageDecoder.h:65:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/network/ResourceRequestBase.h:44:  One space before end of line comments  [whitespace/comments] [5]
> Source/WebCore/platform/graphics/BitmapImage.h:164:  One space before end of line comments  [whitespace/comments] [5]
> Total errors found: 4 in 14 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

These errors are surely false positives.  Replacing a trailing comma from the last element of a enum with a space, which also has a trailing C++ style comment on the same line, should not generate a style error.  Bug against check-webkit-style reported.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.