[Webkit-unassigned] [Bug 57171] New: check-webkit-style errors on trailing comma replaced by space when comments follow
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 26 19:32:14 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=57171
Summary: check-webkit-style errors on trailing comma replaced
by space when comments follow
Product: WebKit
Version: 528+ (Nightly build)
Platform: PC
OS/Version: Other
Status: UNCONFIRMED
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: bentaylor.solx86 at gmail.com
The example patch failed the check-webkit-style, and I believe this to be a false positive:
The , that is replaced should be acceptable to be replaced by a space " " so that
trailing comments maintain their 'style"
Index: Source/WebCore/platform/network/ResourceRequestBase.h
===================================================================
--- Source/WebCore/platform/network/ResourceRequestBase.h (revision 82026)
+++ Source/WebCore/platform/network/ResourceRequestBase.h (working copy)
@@ -41,7 +41,7 @@ namespace WebCore {
UseProtocolCachePolicy, // normal load
ReloadIgnoringCacheData, // reload
ReturnCacheDataElseLoad, // back/forward or encoding change - allow stale data
- ReturnCacheDataDontLoad, // results of a post - allow stale data and only use cache
+ ReturnCacheDataDontLoad // results of a post - allow stale data and only use cache
};
class ResourceRequest;
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list