[Webkit-unassigned] [Bug 56245] Text on path positioning at zero startOffset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56245


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87035|review?                     |review+
               Flag|                            |




--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2011-03-26 12:58:54 PST ---
(From update of attachment 87035)
View in context: https://bugs.webkit.org/attachment.cgi?id=87035&action=review

Great catch, r=me with one change:

> Source/WebCore/platform/graphics/Path.cpp:108
> +    if (!length)
> +        traversalState.m_desiredLength = FLT_EPSILON;
> +    else
> +        traversalState.m_desiredLength = length;

I'd use here traversalState.m_desiredLength = length ? length : std::numeric_limits<float>::epsilon())

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.