[Webkit-unassigned] [Bug 57157] [Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 26 11:50:11 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57157


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-03-26 11:50:11 PST ---
Attachment 87033 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebsettings.cpp', u'..." exit_code: 1

Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.cpp:28:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.h:31:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list