[Webkit-unassigned] [Bug 56825] [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56825





--- Comment #19 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-26 10:26:23 PST ---
(From update of attachment 86933)
View in context: https://bugs.webkit.org/attachment.cgi?id=86933&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:161
> +    // Used by GraphicsContext3D to check whether construction was done succesfully.

Not sure that comment brings much value, anyway it is called "successfully" with 3 s's in total.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:320
> +    // No need viewport of QGLWidget. We use to get a separate QGLContext.

I dont understand that comment

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:475
> +    if (((width == m_boundingRect.width()) && (height == m_boundingRect.height())))

Are all those ()'s needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.