[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 20:51:01 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=27551


Kevin Ollivier <kevino at theolliviers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87006|                            |review?
               Flag|                            |




--- Comment #115 from Kevin Ollivier <kevino at theolliviers.com>  2011-03-25 20:51:00 PST ---
Created an attachment (id=87006)
 --> (https://bugs.webkit.org/attachment.cgi?id=87006&action=review)
Step 2, part 1: Add export symbols, and get the wx port using them.

And here it is finally, the Big Kahuna patch. :) I've tried to export only the symbols actually used whenever possible, and when I did exported the class itself, it was due to the need to export the vtable, etc. Note however that when I export the specific symbols rather than the class itself, MSVC spits out a ton of warnings, so when we do the Windows port we'll need to either silence those warnings or be a bit more liberal about exporting classes themselves. Also, I used JS_EXPORTDATA in a few instances to keep the ports not using the new export macros building, as mentioned earlier once all ports are moved over that define will be merged with JS_EXPORT_PRIVATE. 

Oh, and I can vouch that it builds and runs on wx fine and there aren't to my knowledge any other reviewers familiar with the wx build system, so please don't hold on the review waiting for someone to verify the wx parts. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list