[Webkit-unassigned] [Bug 54406] png-1.5 fixes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54406


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83972|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #15 from David Levin <levin at chromium.org>  2011-03-25 15:27:57 PST ---
(From update of attachment 83972)
View in context: https://bugs.webkit.org/attachment.cgi?id=83972&action=review

Just a minor fix up needed and then this can go in.

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:323
> +        /* '0' argument to png_process_data_pause means: do not save the data */

Use C++ style comments and whole sentences.

// '0' argument to png_process_data_pause means: Do not save the data.

I was confused by what "saving the data" referred to. From reading http://libpng.git.sourceforge.net/git/gitweb.cgi?p=libpng/libpng;a=blobdiff;f=libpng-manual.txt;h=3caff8f9b7019891fd3d0b08ce134ea7e99140e2;hp=b34ffcc1343407687d6723f1132e69f0cdc34941;hb=0a5c9c02faf9c6ceb7acc40e6219e04194581287;hpb=155ce4021812da5629aaebcc9484094944e7d7ae, it means that png should not cache unprocessed bytes.


Perhaps something like this instead?
  m_reader->setReadOffset(m_reader->currentBufferSize() - png_process_data_pause(png, 0 /* Don't cache unprocessed data. */ ));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.