[Webkit-unassigned] [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56397


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86035|review?                     |review-
               Flag|                            |




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-25 14:39:25 PST ---
(From update of attachment 86035)
View in context: https://bugs.webkit.org/attachment.cgi?id=86035&action=review

> LayoutTests/fast/loader/unload-alert.html:9
> +  // Once dialogs are disabled on all platforms, change these to "FAIL" so that
> +  // if the dialogs appear, it's obvious that the test failed.
> +  alert("PASS");
> +  confirm("PASS");
> +  prompt("PASS", "PASS");

This test doesn't make sense on chromium, does it?  If any of PASS appear on chromium platform, it actually failed, right?  I don't think it's clear at all from the test output or from the comment here.

> Source/WebCore/page/Chrome.cpp:62
> +static inline bool canRunModalDuringUnload()
> +{
> +#if PLATFORM(CHROMIUM)
> +    return false;
> +#else
> +    return true;
> +#endif
> +}

I don't think this is the right way to do it if we want to make decisions per port.  We should add a new callback to WebView or some other class instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.