[Webkit-unassigned] [Bug 57104] getCSSCanvasContext does not work with SKIA_GPU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57104





--- Comment #10 from James Robinson <jamesr at chromium.org>  2011-03-25 14:17:57 PST ---
(From update of attachment 86973)
View in context: https://bugs.webkit.org/attachment.cgi?id=86973&action=review

We can discuss the best fix in person on Monday.  In the meantime I've annotated some other issues that need to be addressed if we want to continue with this patch.

> Source/WebCore/ChangeLog:5
> +        Make getCSSCanvasContext work on chromium using SKIA_GPU

You need a link to the bug as well - see the (brief) section in http://www.webkit.org/coding/contributing.html about ChangeLogs.

the webkit-patch upload script will generate a properly formatted stub for you.

> Source/WebCore/ChangeLog:7
> +        No new tests. (OOPS!)

Having the (OOPS!) here will will fail a presubmit check.  Delete this line and replace it with some text describing what the change does and why it doesn't need new tests (in this case because the functionality is already handled by existing tests - it'd be helpful to lists which tests are included).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.