[Webkit-unassigned] [Bug 56138] Data race between ~WorkerFileSystemCallbacksBridge and runTasksOnWorkerThread

Fri Mar 25 13:05:48 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56138

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86901|review?                     |review-
               Flag|                            |

--- Comment #7 from David Levin <levin at chromium.org>  2011-03-25 13:05:48 PST ---
(From update of attachment 86901)
View in context: https://bugs.webkit.org/attachment.cgi?id=86901&action=review

Just a few things but they may change the code a bit so I'd like to see it one more time.

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:89
>      static MainThreadFileSystemCallbacks* createLeakedPtr(PassRefPtr<WorkerFileSystemCallbacksBridge> bridge, const String& mode)

This should no longer be a PassRefPtr (which implies that it keeps the ref count in some way and that is clearly not the case anymore).

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:385
>      { // Let go of the mutex before possibly deleting this due to m_selfRef.clear().

This comment and the brace are now out of date.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.