[Webkit-unassigned] [Bug 57074] REGRESSION: 10 MB increase in CachedScripts on Membuster

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 10:28:04 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57074





--- Comment #3 from Michael Saboff <msaboff at apple.com>  2011-03-25 10:28:05 PST ---
Stephanie's change in the patch focuses on the during test memory usage while my earlier change addressed retained CachedScript data after MemBuster has finished.  From her email comment:

Michael was testing the end of the test whereas I am looking at the high water mark.  I also saw his change as a win for the end of the test.

Michaels change was in response to the bug I filed that said that data from JSC parser was hanging around after all the windows had been closed.  Michaels change fixed this by adding a timer to destroy CachedScript decoded data and as part of that to clear the SourceProviderCache.  It was a win for the end of membuster.  In adding the timer he removed the optimization to immediately throw away decoded data from CachedScripts regressing the high water mark.  Since closing the window would trigger his timer it wouldn't have been obvious from the end of the test that the high water mark had increased.

I agree with this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list