[Webkit-unassigned] [Bug 56989] webkit-patch should be more intelligent about whether a bug applies to a patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56989





--- Comment #10 from Tony Chang <tony at chromium.org>  2011-03-25 09:54:08 PST ---
(From update of attachment 86882)
View in context: https://bugs.webkit.org/attachment.cgi?id=86882&action=review

>> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:61
>> +            "^\s*" + Bugzilla.bug_server_regex + "show_bug\.cgi\?id=(?P<bug_id>\d+)(&ctype=xml)?$",
> 
> Interesting. If we're going to handle this, we should probably also handle the case where ctype comes before the id?

Drive-by-nit: These string literals should be prefixed with 'r' to make it clear you don't want backslashes to be escaped.

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:65
> +            Bugzilla.bug_server_regex + "show_bug\.cgi\?id=(?P<bug_id>\d+)",

This string too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.