[Webkit-unassigned] [Bug 48512] [GTK] Implement sample browser app for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48512





--- Comment #18 from Alejandro G. Castro <alex at igalia.com>  2011-03-25 08:31:40 PST ---
(In reply to comment #16)
> (From update of attachment 86627 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86627&action=review
> 
> Sorry. I missed a few things. :/ My only issues here are minor style issues, but I feel like the change to createWindow will need another round.
> 
> > Tools/MiniBrowser/gtk/main.c:29
> > +// FIXME: replace bool type in the C API
> > +// https://bugs.webkit.org/show_bug.cgi?id=56668
> 
> I guess we may eventually need to add the stdbool.h to the headers ourselvses. :/
> 

Yep, I'll add it to the  WKBaseGtk.h.

> > Tools/MiniBrowser/gtk/main.c:33
> > +#include <WebKit2/WebKit2.h>
> > +#include <gtk/gtk.h>
> 
> You shoud reorder these includes.
> 

I think it assumes gtk is external and will complain if we reorder, like it does for the stdbool.h, but in that case we need it before the webkit2.h.

> > Tools/MiniBrowser/gtk/main.c:144
> > +    WKViewRef webView;
> > +    GtkWidget *mainWindow;
> > +    mainWindow = createWindow(&webView);
> > +
> 
> I think I just realized what's confusing me about this bit. Here's my suggested change:
> 
> 1. Create the WKWebView externally with a helper: createWebView.
> 2. Pass the WebView widget to createWindow.
> 
> In the end it will look like this:
> 
> WkViewRef webView = createWebView();
> GtkWidget *mainWindow = createWindow(&webView);

I understand, I like it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.