[Webkit-unassigned] [Bug 56825] [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56825


Jarkko Sakkinen <jarkko.j.sakkinen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86932|0                           |1
        is obsolete|                            |
  Attachment #86932|review?                     |
               Flag|                            |
  Attachment #86933|                            |review?, commit-queue?
               Flag|                            |




--- Comment #17 from Jarkko Sakkinen <jarkko.j.sakkinen at gmail.com>  2011-03-25 07:28:47 PST ---
Created an attachment (id=86933)
 --> (https://bugs.webkit.org/attachment.cgi?id=86933&action=review)
Style and cosmetic fixes.

Comment on common implementation (summary of the flood in IRC):

If you want common implementation there must a driver class for these features (platform dependent):
- Symbol resolution (GC3DOGL assumes that symbols are resolved)
- Some calls differ whether compiled for OGL ES 2 or desktop GL. ES 2.0 flagging is not done in the GC3DOGL.
- Context handling
- Painting of canvas

These already cover so huge chunk of GC3DQt that I think it would not be a good idea to go for common. Or at least there has to be good answers where platform dependent parts are placed. I think this is something that should be considered in long-term but not for the first release at least :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.