[Webkit-unassigned] [Bug 56929] [Qt] Tiled painting still causes synchronous layout when accelerated compositing and texture mapper are enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56929


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86696|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Benjamin Poulain <benjamin at webkit.org>  2011-03-25 03:35:39 PST ---
(From update of attachment 86696)
View in context: https://bugs.webkit.org/attachment.cgi?id=86696&action=review

> Source/WebKit/qt/Api/qwebframe.cpp:316
> -    renderRelativeCoords(context, (QWebFrame::RenderLayer)(QWebFrame::ScrollBarLayer | QWebFrame::PanIconLayer), clip);
> +    renderFrameWidgets(context, (QWebFrame::RenderLayer)(QWebFrame::ScrollBarLayer | QWebFrame::PanIconLayer), clip);

Maybe change the signature to use QFlags and avoid the ugly cast?

> Source/WebKit/qt/Api/qwebframe.cpp:391
> +void QWebFramePrivate::renderFrameWidgets(GraphicsContext* context, QWebFrame::RenderLayer layer, QRegion clip)

I think the name Widgets is missleading here because of the PanIconLayer (and someone could think page's widgets are rendered here).

What about:
::renderFrameOverlayLayers()
or simply ::renderFrameScollbarAndPanIconLayer() :)

> Source/WebKit/qt/Api/qwebframe.cpp:394
> +    if (!layer & (QWebFrame::PanIconLayer | QWebFrame::ScrollBarLayer))
> +        return;

This could be an assertion instead of a runtime check.

If someone call the method with layer == Content, he clearly made a mistake and should be notified. In QWebFramePrivate::renderRelativeCoords(), you would mask the layer to get the right flags and make the call explicit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.