[Webkit-unassigned] [Bug 57017] [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57017





--- Comment #3 from Kristian Amlie <kristian.amlie at nokia.com>  2011-03-25 01:20:47 PST ---
(In reply to comment #2)
> (From update of attachment 86776 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86776&action=review
> 
> Why do you add the isEmpty(QT_SOURCE_TREE)?

Because if the QtKernel sources are available (as indicated by the existence of QT_SOURCE_TREE), then qtLibraryTarget will already have been called from within qbase.pri. This can happen in the case where you build the modularized Qt modules in development mode, where the modules can see each others sources. If building for release, then this will not be the case, and the qtLibraryTarget needs to be called.

Long term, the reliance on qbase.pri in QT_SOURCE_TREE should be removed, but this will be some additional work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.