[Webkit-unassigned] [Bug 57091] <keygen> does not support autofocus

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 00:44:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57091


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86905|review?                     |review-
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2011-03-25 00:44:06 PST ---
(From update of attachment 86905)
View in context: https://bugs.webkit.org/attachment.cgi?id=86905&action=review

> LayoutTests/fast/forms/autofocus-keygen.html:16
> +    shouldBe('focusedElement', 'document.querySelector("keygen")');

I think document.activeElement works instead of focusedElement.

> LayoutTests/fast/forms/autofocus-keygen.html:23
> +successfullyParsed = true;
> +</script>
> +</head>
> +<body onload="onLoad();">

This doesn't follow usual style of our layout tests.

Please do:
 - remove layoutTestController.dumpAsText() in the second <script>
 - add window.jsTestisAsync = true in the second <script>
 - add finishJSTest() at the bottom of onLoad()
 - add <script> for js/resources/js-test-post.js at the bottom of <body>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list