[Webkit-unassigned] [Bug 56989] webkit-patch should be more intelligent about whether a bug applies to a patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56989





--- Comment #6 from Ojan Vafai <ojan at chromium.org>  2011-03-24 22:06:21 PST ---
(In reply to comment #5)
> > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:53
> > > +def parse_bug_id(message, show_bug_url_on_own_line=False):
> > 
> > I don't see why you need this argument. As best I can tell, all the paces where this is used are to get the bug ID out of a changelog/commit entry and they should all have the same format. Is there a case that breaks if you just always restrict to searching for the bug url on it's own line?
> 
> Currently sheriff_unittest.py creates a string "Created bug https://bugs.webkit.org/..." which is used as an input to parse_bug_id().  
> 
> I could alter this particular test, but my concern is potentially breaking anything that may be lacking robust unittests that assumes that a non-start-of-line match of a bug URL is handled by parse_bug_id()

Oh. I see. Yeah, create_bug uses that output. I'd prefer for the default to be True here since the sheriffbot case is the exception.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.