[Webkit-unassigned] [Bug 56989] webkit-patch should be more intelligent about whether a bug applies to a patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56989


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86875|review?                     |review-
               Flag|                            |




--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2011-03-24 21:14:59 PST ---
(From update of attachment 86875)
View in context: https://bugs.webkit.org/attachment.cgi?id=86875&action=review

The regexp and tests look good. Just not sure about the need for an argument.

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:53
> +def parse_bug_id(message, show_bug_url_on_own_line=False):

I don't see why you need this argument. As best I can tell, all the paces where this is used are to get the bug ID out of a changelog/commit entry and they should all have the same format. Is there a case that breaks if you just always restrict to searching for the bug url on it's own line?

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:59
> +    if show_bug_url_on_own_line == False:

If you invert the order here, you can just check "if show_bug_url_on_own_line". Also, general preferred style is to use "if bool" or "if not bool" instead of comparing to True/False.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.