[Webkit-unassigned] [Bug 54330] [chromium] Cannot use multiple accelerated 2D canvas' in the same render process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54330


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86811|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from James Robinson <jamesr at chromium.org>  2011-03-24 12:45:47 PST ---
(From update of attachment 86811)
View in context: https://bugs.webkit.org/attachment.cgi?id=86811&action=review

DrawingBuffer holds a RefPtr to its associated GraphicsContext3D, so the GraphicsContext3D will never be destroyed before the DrawingBuffer.

Does this code assuming that the GrContext is the only user of the SharedGraphicsContext3D?

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:53
> +// limit the number of textures we hold in the bitmap->texture cache
> +#define GR_MAX_TEXTURE_COUNT    512
> +// limit the bytes allocated toward textures in the bitmap->texture cache

Comments in WebKit should start with a capital letter and end with a period.

Also, we typically use static variables of the appropriate type (size_t here) instead of #defines for stuff like this.

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:474
> +        m_grContext->setTextureCacheLimits(GR_MAX_TEXTURE_COUNT,
> +                                           GR_MAX_TEXTURE_BYTES);

unnecessary line wrap

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.