[Webkit-unassigned] [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54969


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86512|review?                     |review-
               Flag|                            |




--- Comment #16 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-24 12:25:06 PST ---
(From update of attachment 86512)
View in context: https://bugs.webkit.org/attachment.cgi?id=86512&action=review

The gist looks great to me. You've done well whittling down redudancies! I'd like two peeps to take a look at this before landing: rniwa (ranges/editing stuff) and weinig (webkit2 stuff). r- to nit.

> Source/WebCore/ChangeLog:16
> +        * WebCore.exp.in:
> +        * dom/Range.cpp:
> +        (WebCore::Range::getLocationAndLength):
> +        * dom/Range.h:
> +        * page/Frame.cpp:
> +        (WebCore::Frame::rangeForPoint):
> +        * page/Frame.h:

This is sad and lonely. I'd like it to be full of life and meaning.

> Source/WebKit/chromium/ChangeLog:28
> +        * WebKit.gyp:
> +        * public/WebFrame.h:
> +        * public/WebWidget.h:
> +        * public/mac/WebTextHelper.h: Added.
> +        * src/WebFrameImpl.cpp:
> +        (WebKit::WebFrameImpl::firstRectForCharacterRange):
> +        (WebKit::WebFrameImpl::characterIndexForPoint):
> +        * src/WebFrameImpl.h:
> +        * src/WebPopupMenuImpl.cpp:
> +        (WebKit::WebPopupMenuImpl::compositionRange):
> +        (WebKit::WebPopupMenuImpl::caretOrSelectionRange):
> +        * src/WebPopupMenuImpl.h:
> +        * src/WebViewImpl.cpp:
> +        (WebKit::WebViewImpl::compositionRange):
> +        (WebKit::WebViewImpl::caretOrSelectionRange):
> +        * src/WebViewImpl.h:
> +        * src/mac/WebTextHelper.mm: Added.
> +        (WebKit::getWebFrameImpl):
> +        (WebKit::rangeScope):
> +        (WebKit::WebTextHelper::WebTextHelper):
> +        (WebKit::WebTextHelper::substringInRange):

Ditto. At least explain what you're doing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.