[Webkit-unassigned] [Bug 40884] [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40884


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86801|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-24 11:40:34 PST ---
(From update of attachment 86801)
View in context: https://bugs.webkit.org/attachment.cgi?id=86801&action=review

Pretty nice testing!

> Source/WebKit/qt/tests/benchmarks/webgl/tst_webgl.cpp:31
> +class tst_WebGlPerformance : public QObject {

We normally use GL as uppercase (ie QGLWidget)

> Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:475
> +        for (int column = 0; column < image1.size().height(); ++column)
> +            if (image1.pixel(row, column) != image2.pixel(row, column))
> +                ++diffPixelCount;

That for should really use {}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.