[Webkit-unassigned] [Bug 56948] Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56948


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86791|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2011-03-24 10:23:09 PST ---
(From update of attachment 86791)
View in context: https://bugs.webkit.org/attachment.cgi?id=86791&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1130
> +    if (!isFocused)
> +        m_page->focusController()->focusedOrMainFrame()->selection()->clear();

Sam said: “Before this line, you should add RefPtr<WebPage> protect(this)”.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.