[Webkit-unassigned] [Bug 54330] [chromium] Cannot use multiple accelerated 2D canvas' in the same render process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54330





--- Comment #3 from Stephen White <senorblanco at chromium.org>  2011-03-24 10:13:26 PST ---
(From update of attachment 86781)
View in context: https://bugs.webkit.org/attachment.cgi?id=86781&action=review

Looks ok to me, modulo nits.

> WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:177
> +    SkRefCnt_SafeAssign(m_grContext, context);

With both DrawingBuffer and SGC3D taking a ref on the GrContext, ownership semantics are a bit muddy.  If jamesr can confirm that the DrawingBuffer never outlives the SGC3D, we could use a bare pointer, and not take a ref here.

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:469
> +        m_grContext->setTextureCacheLimits(512, 50 * 1024 * 1024);

These magic numbers should probably be in a constant whose name explains their meaning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.