[Webkit-unassigned] [Bug 20302] Wrong signbit implementation for solaris platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20302


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86785|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-03-24 09:53:43 PST ---
(From update of attachment 86785)
View in context: https://bugs.webkit.org/attachment.cgi?id=86785&action=review

> Source/JavaScriptCore/wtf/MathExtras.h:93
> -inline bool signbit(double x) { return x < 0.0; } // FIXME: Wrong for negative 0.
> +inline bool signbit(double num) { return copysign(1.0, num) < 0; }

I guess you copied the version from MSVC, which is why the variable name is now num. I would prefer that this file use "x" more consistently or use a word like "number" rather than "num".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.