[Webkit-unassigned] [Bug 56962] [Chromium] Vertical Japanese text is not displayed on Snow Leopard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56962





--- Comment #6 from Mark Mentovai <mark at chromium.org>  2011-03-24 07:41:19 PST ---
If WebKit already has a function to get the OS version, it’s probably better to call that.

If you’re concerned about bloating the object code size for Apple-style WebKit, which is built for a specific OS release, you can use macros to hide your tests. In some cases, you can use this in conjunction with compiler optimizations to keep things clean and workable. For example:

#if BUILD_TIME_CHECK_FOR_LEOPARD
  bool useNewThing = false;
#elif BUILD_TIME_CHECK_FOR_SNOW_LEOPARD
  bool useNewThing = true;
#else
  bool useNewThing = RuntimeCheckForSnowLeopard();
#endif

  if (useNewThing) {
    // ...
  }

Depending on the macros available, it may be easier to write this as

#if CHROMIUM
  bool useNewThing = RuntimeCheckForSnowLeopard();
#elif BUILD_TIME_CHECK_FOR_LEOPARD
  bool useNewThing = false;
// ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.